This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/server: Block on instance deployment becoming available #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an extra _optional_ timeout that blocks on having a request returned when listing instances by deployment ID. The default general case is to not block at all, but allows the caller to define an optional timeout and block on a deployment ID existing before returning the requested result.
mitchellh
reviewed
Dec 3, 2020
mitchellh
reviewed
Dec 3, 2020
|
@mitchellh yeah, def agree we need a proper test. I wasn't 100% sure how to go about it so I'd love to pair! We can coordinate on slack |
mitchellh
reviewed
Dec 3, 2020
mitchellh
approved these changes
Dec 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an extra optional timeout that blocks on having a
request returned when listing instances by deployment ID. The default
general case is to not block at all, but allows the caller to define an
optional timeout and block on a deployment ID existing before returning
the requested result.
This commit does not fully fix #683, as there are more complex CLI
changes required to leverage this server change.