Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

feature: Uninstall server for all platforms #972

Merged
merged 21 commits into from
Jan 15, 2021
Merged

feature: Uninstall server for all platforms #972

merged 21 commits into from
Jan 15, 2021

Conversation

krantzinator
Copy link
Contributor

Along with uninstall work I also:

  • added a const for serverName that all platforms use
    • replaced k8s serverName and serviceName flags with consts
  • made small improvements to Nomad install
  • minor formatting in unrelated commands for consistency

@krantzinator krantzinator added this to the 0.2.x milestone Jan 13, 2021
@krantzinator krantzinator requested a review from a team January 13, 2021 18:45
mitchellh
mitchellh suggested changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, really minor feedback this looks great!

internal/cli/uninstall.go Outdated Show resolved Hide resolved
internal/cli/uninstall.go Outdated Show resolved Hide resolved
internal/cli/uninstall.go Outdated Show resolved Hide resolved
internal/serverinstall/docker.go Outdated Show resolved Hide resolved
internal/serverinstall/docker.go Outdated Show resolved Hide resolved
internal/serverinstall/docker.go Outdated Show resolved Hide resolved
internal/serverinstall/docker.go Show resolved Hide resolved
internal/serverinstall/k8s.go Outdated Show resolved Hide resolved
briancain
briancain suggested changes Jan 13, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks good to me!! Just requesting a small change on a function name and then I'll be sure to do some manual testing on my end soon :) 👍

internal/serverinstall/nomad.go Outdated Show resolved Hide resolved
internal/cli/uninstall.go Outdated Show resolved Hide resolved
@briancain briancain mentioned this pull request Jan 13, 2021
Merged
@krantzinator krantzinator linked an issue Jan 14, 2021 that may be closed by this pull request
Uninstall/Remove Waypoint #672
Closed
@krantzinator @briancain
Update internal/cli/uninstall.go
4caf814 
Co-authored-by: Brian Cain <bcain@hashicorp.com>
@krantzinator krantzinator merged commit 3a9d48b into main Jan 15, 2021
@krantzinator krantzinator deleted the f-uninstall branch January 15, 2021 22:39
@hc-waypoint-bot hc-waypoint-bot mentioned this pull request Jan 15, 2021
Closed
@krantzinator krantzinator mentioned this pull request Jan 15, 2021
Merged
@krantzinator krantzinator modified the milestones: 0.2.x, 0.2.1 Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitchellh mitchellh mitchellh approved these changes

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
core website
Projects
None yet
Milestone
0.2.1
Development

Successfully merging this pull request may close these issues.

Uninstall/Remove Waypoint
3 participants
@krantzinator @mitchellh @briancain