This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
internal/client: use given context so it can be cancelled #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While attempting to connect to a server, Ctrl-C was not working. This is because we were using `context.Background` rather than the passed in context when attempting to connect. I don't know why we did this, it looks like a simple mistake from dev. Verified that this makes Ctrl-C work properly for server connection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to connect to a server, Ctrl-C was not working. This is
because we were using
context.Backgroundrather than the passed incontext when attempting to connect.
I don't know why we did this, it looks like a simple mistake from dev.
Verified that this makes Ctrl-C work properly for server connection.
Labeling for backport to 0.2.x.