Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional-packages #283

Closed
RyanGlScott opened this issue Jun 16, 2019 · 4 comments
Closed

Add support for optional-packages #283

RyanGlScott opened this issue Jun 16, 2019 · 4 comments

Comments

@RyanGlScott
Copy link
Contributor

I can't use haskell-ci in the gl repo at the moment because haskell-ci won't generate the necessary commands to build the gl subdirectory, which is listed as optional-packages: gl in the cabal.project file.

@phadej
Copy link
Collaborator

phadej commented Jun 24, 2019

Why gl is optional-package?

@RyanGlScott
Copy link
Contributor Author

No idea. I don't make the news, I just report it.

@phadej
Copy link
Collaborator

phadej commented Jun 24, 2019

https://cabal.readthedocs.io/en/latest/nix-local-build.html#cfg-field-optional-packages

Like packages, specifies a list of package locations containing local packages to be built. Unlike packages, if we glob for a package, it is permissible for the glob to match against zero packages. The intended use-case for optional-packages is to make it so that vendored packages can be automatically picked up if they are placed in a subdirectory, but not error if there aren’t any.

It seems, one should use packages, as gl.cabal is always there, isn't it? Even it's regenerated, it's still there (the old one).

@phadej phadej closed this as completed Jun 24, 2019
@ekmett
Copy link

ekmett commented Jun 25, 2019

I intend to move to generating the gl.cabal file as well. It really should be generated now but I was being lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants