Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

It no longer compiles on ARM on version 0.16 #90

Closed
varosi opened this issue Jun 9, 2016 · 5 comments
Closed

It no longer compiles on ARM on version 0.16 #90

varosi opened this issue Jun 9, 2016 · 5 comments

Comments

@varosi
Copy link

varosi commented Jun 9, 2016

GHC 7.10.2, Debian Jessie, ARMv7, gcc (Debian 4.9.2-10) 4.9.2

[103 of 103] Compiling Crypto.Cipher.AES ( Crypto/Cipher/AES.hs, dist/build/Crypto/Cipher/AES.o )
cbits/cryptonite_rdrand.c: In function ‘cryptonite_cpu_has_rdrand’:

cbits/cryptonite_rdrand.c:40:2:
error: impossible constraint in ‘asm’
asm volatile ("cpuid": "=a" (ax), "=b" (bx), "=c" (cx), "=d" (dx) : "a" (func));
^
Failed to install cryptonite-0.16

@varosi varosi changed the title It no longer compiles on ARM It no longer compiles on ARM with cryptonite-0.16 Jun 9, 2016
@varosi
Copy link
Author

varosi commented Jun 9, 2016

cryptonite-0.15 works fine

@varosi varosi changed the title It no longer compiles on ARM with cryptonite-0.16 It no longer compiles on ARM on version 0.16 Jun 9, 2016
@centromere
Copy link
Member

Possible duplicate of #88.

@vincenthz
Copy link
Member

hm. fixed in 32aec08. @centromere: looks like you removed the x86_64 guard that was present. rdrand shouldn't be tried on anything non-x86

@centromere
Copy link
Member

@vincenthz The reason for this change was that, if I turned off rdrand, ARCH_X86_64 would never get defined. It doesn't seem logical to me that x86_64 support would be predicated upon rdrand.

The PR you just merged in is similar to what I proposed in the rdrand-fix branch.

@vincenthz
Copy link
Member

@centromere: the first part of the change make perfect sense, indeed X86_64 support should have been separate just like you made it. I missed the side effect of moving it instead of copying it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants