-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly expose errors/exceptions #49
Comments
I've added a schema of the current threading+error propagation model, showing a risk of leaking low-level asyncs if a remote/the kernel does not close TCP and no-one called an explicit close on the RawConnection object. https://docs.google.com/presentation/d/1WxP7HkTHy7Rr8sA-9NydD5jRcWbFffW2yM4Pv61OCfI/edit?usp=sharing The schema doesn't go in some level of detail (e.g., using |
The branch https://github.com/lucasdicioccio/http2-client/tree/stop-polling-on-eof is already likely adding an ExceptT layer to collect exceptions, currently hiding everything out of the existing user-facing APIs. |
#67 Has done much of the basics needed for this. |
It's about time we start exposing errors and exception to API users.
The new dispatch mechanism allows to have fewer entry points, which makes the exception handling tracktable.
There are two broad types of errors we may want to catch and expose differently:
Currently the design was mostly ad-hoc, with a mix of HTTP2 errors and uncaught exeptions.
The text was updated successfully, but these errors were encountered: