Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SETTINGS_MAX_HEADER_LIST_SIZE #8

Open
lucasdicioccio opened this issue Aug 13, 2017 · 1 comment
Open

Handle SETTINGS_MAX_HEADER_LIST_SIZE #8

lucasdicioccio opened this issue Aug 13, 2017 · 1 comment

Comments

@lucasdicioccio
Copy link
Member

We could error early if a client tries to send too many headers at once (it's unclear to me whether the RFC refers to a per-frame limitation or a total limitation). The RFC is permissive as to whether it allows senders to overpass the limit:

SETTINGS_MAX_HEADER_LIST_SIZE (0x6):  This advisory setting informs a
      peer of the maximum size of header list that the sender is
      prepared to accept, in octets.  The value is based on the
      uncompressed size of header fields, including the length of the
      name and value in octets plus an overhead of 32 octets for each
      header field.

We should at least provide a function to check whether headers are too large and let library users make their own decisions to use this information or not.

@lucasdicioccio
Copy link
Member Author

lucasdicioccio commented Aug 19, 2017

This bug is very related to #4 , hence hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant