You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for the great work, we've been using simanSolve with great success so far!
We did notice some details in the API that could be improved though:
The n_tries attribute of SimulatedAnnealingParams is completely unused. It is used by gsl's function gsl_siman_solve_many but hamtrix-gsl's simanSolve function interfaces with gsl_siman_solve. We found it particularly confusing when we noticed that changing the value of that parameter did not have any impact onto the number of energy evaluations (and therefore no impact at all on computational time). The API would be much clearer if the parameter was removed from SimulatedAnnealingParams.
Similarly the distance function or "metric definition", the 6th argument of the simanSolve function, is completely unused. Again the API would gain in clarity by removing the argument altogether or at least clarify its uselessness in the documentation of the function.
Thanks again for implementing the GSL bindings!
The text was updated successfully, but these errors were encountered:
Issue description
Thank you for the great work, we've been using
simanSolve
with great success so far!We did notice some details in the API that could be improved though:
The
n_tries
attribute ofSimulatedAnnealingParams
is completely unused. It is used bygsl
's function gsl_siman_solve_many but hamtrix-gsl'ssimanSolve
function interfaces with gsl_siman_solve. We found it particularly confusing when we noticed that changing the value of that parameter did not have any impact onto the number of energy evaluations (and therefore no impact at all on computational time). The API would be much clearer if the parameter was removed fromSimulatedAnnealingParams
.Similarly the
distance
function or "metric definition", the 6th argument of thesimanSolve
function, is completely unused. Again the API would gain in clarity by removing the argument altogether or at least clarify its uselessness in the documentation of the function.Thanks again for implementing the GSL bindings!
The text was updated successfully, but these errors were encountered: