Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unsafeShiftR in utf8Encode #129

Open
sjakobi opened this issue Nov 21, 2018 · 3 comments
Open

Use unsafeShiftR in utf8Encode #129

sjakobi opened this issue Nov 21, 2018 · 3 comments

Comments

@sjakobi
Copy link
Member

sjakobi commented Nov 21, 2018

That could be a tiny bit faster than the current use of shiftR.

Since unsafeShiftR has been in base since v4.5 / GHC-7.4, could it even be used unconditionally?! alex currently claims a rather dubious lower bound on base of >= 1.0…
@andreasabel
Copy link
Member

It is not entirely clear to me which GHC versions Alex wants to support. The currently lowest version tested on travis is 7.0.4. (See ae56173.)

@simonmar
Copy link
Member

Let's keep support for 7.0.4 while it still works. If it becomes hard to support/test older versions we can increase the lower bound in the future.

@simonmar simonmar reopened this Jan 27, 2020
@andreasabel
Copy link
Member

NB: The current (3.2.7) lower bound on base is >= 2.1. GHC-7.0 is 4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonmar @andreasabel @sjakobi