Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with GHC's JavaScript backend #625

Closed
clyring opened this issue Nov 7, 2023 · 1 comment · Fixed by #631
Closed

Compatibility with GHC's JavaScript backend #625

clyring opened this issue Nov 7, 2023 · 1 comment · Fixed by #631
Milestone

Comments

@clyring
Copy link
Member

clyring commented Nov 7, 2023

It's my understanding that the C FFI as used by the bytestring library is not well-supported by the JavaScript backend. To work around this we can add fallback Haskell-only implementations and use these whenever an appropriate cabal flag is set.

See also earlier discussion at #573.

@clyring
Copy link
Member Author

clyring commented Nov 7, 2023

Question: #587 added more reliance on the C FFI because of alignment issues. I assume the unaligned writes themselves are not really a problem, but the patch also moves some static data tables from Haskell code into C code so that we can read multi-byte values from them in Haskell code without worrying about alignment or endian-ness. Will that need a workaround? I hope it's easier for the JS backend to support than passing ByteArray#s and such into general C code.

@clyring clyring linked a pull request Dec 12, 2023 that will close this issue
@clyring clyring added this to the 0.12.1.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant