Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prereleases not updating GitHub release #10652

Closed
TeofilC opened this issue Dec 19, 2024 · 12 comments
Closed

Prereleases not updating GitHub release #10652

TeofilC opened this issue Dec 19, 2024 · 12 comments

Comments

@TeofilC
Copy link
Collaborator

TeofilC commented Dec 19, 2024

It looks like the cabal-head release hasn't been updated since Oct 3 https://github.com/haskell/cabal/releases/tag/cabal-head

Yet the pipelines on master seem to be succeeding and claim to be updating it, eg, https://github.com/haskell/cabal/actions/runs/12399481693/job/34618533301

@geekosaur
Copy link
Collaborator

Hm. It also says it updated the artifacts as the prerelease job shows, even though the metadata says it's still for an old commit.

@TeofilC
Copy link
Collaborator Author

TeofilC commented Dec 19, 2024

I'm suspicious that it's not actually being updated because I don't see #10653 using those artifacts but I am seeing it using the ones I'm getting from the HEAD commit manually

@TeofilC
Copy link
Collaborator Author

TeofilC commented Dec 19, 2024

Actually I think I'm mistaken. diff tells me they are identical

@TeofilC TeofilC closed this as completed Dec 19, 2024
@geekosaur geekosaur reopened this Dec 19, 2024
@geekosaur
Copy link
Collaborator

geekosaur commented Dec 19, 2024

I think we're using a buggy release action, since it should be updating the metadata. I'm going to look for alternative actions. (We switched to the current action because the one we were using is unmaintained, but to date it's been nothing but trouble.)

@geekosaur
Copy link
Collaborator

Also: @ulysses4ever, I know you disagree with its scope, but I think we really should land #10541; if nothing else, it would make it easier to verify what commit these prereleases are on. The previous behavior of this particular release action had it supposedly making prereleases, but they were all of the same old commit.

@TeofilC
Copy link
Collaborator Author

TeofilC commented Dec 19, 2024

FWIW I agree that it would be really helpful if prerelases would tell me the commit when I run cabal --version, otherwise it's very easy to lose track of what version you have

@ulysses4ever
Copy link
Collaborator

This is a dup #10537

@ulysses4ever
Copy link
Collaborator

Also: @ulysses4ever, I know you disagree with its scope, but I think we really should land #10541

Did you see my last comment there? I'm all for merging it basically in any form. I thought I approved it but now I see I didn't. Maybe CI wasn't ready or something. I'll make sure to take a look and approve it today. Thanks for working on it!

@geekosaur
Copy link
Collaborator

I had it flagged as draft, for one. It's now marked as ready for review.

@ulysses4ever
Copy link
Collaborator

@TeofilC do you have energy to resubmit my ulysses4ever@de17531 to fix this issue? I accidentally killed the accompanying PR #10540 (which didn't get any attention in weeks) by resetting my fork, and now someone has to start over...

@TeofilC
Copy link
Collaborator Author

TeofilC commented Dec 19, 2024

@ulysses4ever sure I'd be happy to rebase that and make a PR: #10654

@TeofilC
Copy link
Collaborator Author

TeofilC commented Dec 19, 2024

Resolved by #10654

@TeofilC TeofilC closed this as completed Dec 19, 2024
@ulysses4ever ulysses4ever closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants