Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<pkg-name>.cabal.up for the glob wary #8075

Open
philderbeast opened this issue Mar 31, 2022 · 0 comments
Open

<pkg-name>.cabal.up for the glob wary #8075

philderbeast opened this issue Mar 31, 2022 · 0 comments

Comments

@philderbeast
Copy link
Collaborator

philderbeast commented Mar 31, 2022

I'm wary of using any glob-like features in the .cabal file (and project file). I want reproducible builds and being explicit helps get us there. I don't want to depend on whatever state my file system is in. Globs don't tell me I'm including junk files or am missing essential files that were not checked in to source control.

Could we take all the globbing features and put them in upstream file from which we then generate a .cabal file with globs expanded?

<pkg-name>.cabal.up -> <pkg-name>.cabal

EDIT: note the fact that hpack "works" is because there is clear stage separation. package.yaml is compiled to pkgname.cabal, and pkgname.cabal is used as input to actual build tooling. Blurring the boundary, requiring to .cabal files to be interpreted before further consumption it tricky.
#5343 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant