Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pkg-config logic by removing the batch query #9478

Open
georgefst opened this issue Nov 24, 2023 · 2 comments
Open

Simplify pkg-config logic by removing the batch query #9478

georgefst opened this issue Nov 24, 2023 · 2 comments
Labels
re: pkg-config Concerning pkg-config and pkgconfig-depends constraints type: user-question

Comments

@georgefst
Copy link

georgefst commented Nov 24, 2023

Could we consider just dropping the batch query completely? This was asked in #9134 (comment) and #9134 (comment). AFAICT all it gives us is a fairly small speedup on some systems, while doubling the time for anyone with any broken packages (which is common: #8930) and adding complexity.

(It would be even better if we cached results on a per-package basis, as in #9360.)

Originally posted by @georgefst in #9391 (comment)

@gbaz
Copy link
Collaborator

gbaz commented Nov 24, 2023

As was answered in many other comments, the speedup is not necessarily small.

@grayjay grayjay added the re: pkg-config Concerning pkg-config and pkgconfig-depends constraints label Nov 30, 2023
@georgefst
Copy link
Author

As was answered in many other comments, the speedup is not necessarily small.

Fair enough. My hunch is that the trade-off is worth it, but admittedly I'd have to collect some stats to be sure. If we did do per-package caching like #9360 then I'd expect incremental calls to always be significantly faster (except in an environment with implausibly frequent cache invalidation). But as has been discussed in various linked threads, this isn't easy, and #9422 is mostly an adequate substitute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: pkg-config Concerning pkg-config and pkgconfig-depends constraints type: user-question
Projects
None yet
Development

No branches or pull requests

3 participants