Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we delete the coverage project? #9564

Closed
philderbeast opened this issue Dec 26, 2023 · 0 comments · Fixed by #9574
Closed

Can we delete the coverage project? #9564

philderbeast opened this issue Dec 26, 2023 · 0 comments · Fixed by #9574

Comments

@philderbeast
Copy link
Collaborator

Can we delete cabal.project.coverage? I can't find a reference to it in the codebase and noticed a problem with it:

$ cabal build all --dry-run --project-file=cabal.project.coverage
Error: cabal: Error parsing project file
/.../cabal/cabal.project.coverage:29:
"<eitherParsec>" (line 1, column 6):
unexpected end of input
expecting ".", ":", white space, "+", "-", opening paren, operator,
"installed", "source", "test" or "bench"

Here's the fix (making it like the other projects with similar constraints):

$ git diff
diff --git a/cabal.project.coverage b/cabal.project.coverage
index a6f9eefd0..0efc6bf15 100644
--- a/cabal.project.coverage
+++ b/cabal.project.coverage
@@ -26,7 +26,7 @@ allow-newer: windns-0.1.0.1:base
 
 -- avoiding extra dependencies
 constraints: rere -rere-cfg
-constraints: these
+constraints: these -assoc
 
 program-options
   ghc-options: -fno-ignore-asserts

It now builds:

$ cabal build all --dry-run --project-file=cabal.project.coverage
Resolving dependencies...
Build profile: -w ghc-9.4.7 -O1
In order, the following would be built (use -v for more details):
 - Cabal-syntax-3.11.0.0 (lib) (cannot read state cache)
 - solver-benchmarks-3 (lib) (cannot read state cache)
 - hackage-security-0.6.2.3 (lib) (cannot read state cache)
 - cabal-benchmarks-3 (test:cabal-benchmarks) (cannot read state cache)
 - Cabal-tests-3 (test:rpmvercmp) (cannot read state cache)
 - Cabal-tests-3 (test:no-thunks-test) (cannot read state cache)
 - Cabal-3.11.0.0 (lib) (cannot read state cache)
 - solver-benchmarks-3 (test:unit-tests) (cannot read state cache)
 - solver-benchmarks-3 (exe:hackage-benchmark) (cannot read state cache)
 - cabal-install-solver-3.11.0.0 (lib) (cannot read state cache)
 - Cabal-tree-diff-3.11.0.0 (lib) (cannot read state cache)
 - Cabal-tests-3 (test:custom-setup-tests) (cannot read state cache)
 - Cabal-tests-3 (test:check-tests) (cannot read state cache)
 - Cabal-tests-3 (lib) (cannot read state cache)
 - Cabal-described-3.11.0.0 (lib) (cannot read state cache)
 - Cabal-QuickCheck-3.11.0.0 (lib) (cannot read state cache)
 - cabal-install-solver-3.11.0.0 (test:unit-tests) (cannot read state cache)
 - cabal-install-3.11.0.0 (lib) (cannot read state cache)
 - Cabal-tests-3 (test:parser-tests) (cannot read state cache)
 - Cabal-tests-3 (test:hackage-tests) (cannot read state cache)
 - cabal-testsuite-3 (lib:cabal-testsuite, exe:cabal-tests, exe:setup, exe:test-runtime-deps) (cannot read state cache)
 - Cabal-tests-3 (test:unit-tests) (cannot read state cache)
 - cabal-install-3.11.0.0 (test:unit-tests) (cannot read state cache)
 - cabal-install-3.11.0.0 (test:mem-use-tests) (cannot read state cache)
 - cabal-install-3.11.0.0 (test:long-tests) (cannot read state cache)
 - cabal-install-3.11.0.0 (test:integration-tests2) (cannot read state cache)
 - cabal-install-3.11.0.0 (exe:cabal) (cannot read state cache)
$ cabal --version
cabal-install version 3.10.2.0
compiled using version 3.10.2.1 of the Cabal library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant