Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix expected content-types for documentation tarballs #1348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix expected content-types for documentation tarballs #1348

wants to merge 1 commit into from

Conversation

MangoIV
Copy link
Contributor

@MangoIV MangoIV commented Nov 24, 2024

Fixes #1269

  • documentation tarballs produced by cabal haddock are compressed
  • their mimetype is application/gzip
  • keeps the applicatoin/x-tar and applicatoin/x-gzip even though there is no tar mimetype and there's now (since 2014) a gzip mimetype, according to RFC6713
  • remove the expectUncompressedTarball function as it is now dead code
  • remove a pair of redundant paren and replace infix liftM with <$>

@MangoIV
[fix] fix expected content-types for documentation tarballs
a3f7229 
- documentation tarballs produced by cabal haddock are compressed
- their mimetype is application/gzip
- keeps the applicatoin/x-tar and applicatoin/x-gzip even though there
  is no tar mimetype and there's now (since 2014) a gzip mimetype,
  according to RFC6713
- remove the expectUncompressedTarball function as it is now dead code
- remove a pair of redundant paren and replace infix `liftM` with <$>
@MangoIV
Copy link
Contributor Author

MangoIV commented Nov 24, 2024 •
edited
Loading

Pinging @phadej and @gbaz for review as your were participating in the original issue.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow uploading docs as tar.gz
1 participant
@MangoIV