Publishing a candidate does not delete the candidate

[edsko]

This is strange, because this leaves the database in a state where we have both version X.Y.Z of a package in the packages DB and in the candidates DB. There are some provisions in the code for this (publishCandidate takes a doDelete argument), so I'm not sure what the intention is. But current behaviour seems wrong to me.

Pinging @dcoutts .

[gracenotes]

doDelete has always been False, ever since the call was added in a9e67c3. Afaik there's no reason it can't be, or should have always been, True.

[gracenotes]

btw, I've been away from a computer with any of my ssh credentials, so I've been somewhat limited in being able to actually send patches for the moment :/ Hope the comments help provide context a bit.

[lambda-fairy]

Would the fix for this be to simply change False to True?

The only call to publishCandidate seems to be in the Html feature, on this line.

[hvr]

See #558

[gbaz]

resolved by #895