Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Add QuickCheck tests for FromJSON / ToJSON instances #48

Closed
alanz opened this issue Nov 9, 2015 · 6 comments
Closed

Add QuickCheck tests for FromJSON / ToJSON instances #48

alanz opened this issue Nov 9, 2015 · 6 comments

Comments

@alanz
Copy link
Collaborator

alanz commented Nov 9, 2015

We are hand coding the JSON instances.

Provide quickcheck tests that confirm that we can successfully roundtrip all JSON instances.

i.e. decode . encode == id

@bitemyapp
Copy link
Collaborator

Could we have people make a comment when they're taking a shot at a ticket and let others know when they're setting it aside if they didn't reach a PR-able state?

@alanz
Copy link
Collaborator Author

alanz commented Nov 9, 2015

Or just assign the issue to themselves. The "Asignee" button on the right.

@bitemyapp
Copy link
Collaborator

@alanz ah right, at'll do 'er. 👍

@cocreature
Copy link
Collaborator

Note that you can only assign issues to you if you are part of the project, so especially for newcomers this is not an option.

@alanz
Copy link
Collaborator Author

alanz commented Nov 9, 2015

ok. does anyone need to be added at the moment?

@bitemyapp
Copy link
Collaborator

@alanz perhaps make it known that a comment is an acceptable fallback if somebody that isn't on the project yet wants to claim a ticket and doesn't want to wait to get added? Then someone that is on the project can assign them.

@JPMoresmau JPMoresmau self-assigned this Nov 14, 2015
@gracjan gracjan changed the title Add quickcheck tests for FromJSON / ToJSON instances Add QuickCheck tests for FromJSON / ToJSON instances Nov 17, 2015
@alanz alanz closed this as completed Dec 2, 2015
@alanz alanz added this to the prehistory milestone Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants