Skip to content

Code Action for adding a constructor to imports is a noop #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProofOfKeags opened this issue May 25, 2021 · 4 comments
Closed

Code Action for adding a constructor to imports is a noop #1868

ProofOfKeags opened this issue May 25, 2021 · 4 comments
Labels
status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@ProofOfKeags
Copy link

Your environment

Output of haskell-language-server --probe-tools or haskell-language-server-wrapper --probe-tools:

haskell-language-server version: 1.1.0.0 (GHC: 8.10.4) (PATH: /home/proofofkeags/.local/bin/haskell-language-server-wrapper) (GIT hash: f1c096927186a93d8e3ccd4fe8385cc1b070350b)
Tool versions found on the $PATH
cabal:          3.2.0.0
stack:          2.7.1
ghc:            Not found

Which OS do you use: Linux

Which lsp-client do you use: VSCode

Steps to reproduce

  1. Reference a Constructor that is not imported and shares a name with its type.
  2. Use Ctrl+. to execute code action to add constructor to import list

Expected behaviour

Type and constructor should be added to import list.

Actual behaviour

Only the type is added to the import list

Include debug information

No relevant logs

@Ailrun
Copy link
Member

Ailrun commented May 25, 2021

Thank you for the report. I believe this is a duplicate of #1768, which is fixed in the master branch. Could you try the master branch version of HLS?

@Ailrun Ailrun added status: fixed in master status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels May 25, 2021
@ProofOfKeags
Copy link
Author

It does appear to be a duplicate. Is master stable enough to work off of usually?

@Ailrun
Copy link
Member

Ailrun commented May 27, 2021

Sometimes there's some critical issues, but it's usually only during few commits (so you can go back those few commits to work with "good" version) and I would say it's mostly stable.

@ProofOfKeags
Copy link
Author

Can confirm that this does work on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

2 participants