Restore haddock error reporting for ghc >= 9.0 #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jneira opened this issue Nov 9, 2021 · 0 comments

Labels

type: enhancement

Member

jneira commented Nov 9, 2021 •

edited

Loading

From [GHC 9.0] No need to parse without Haddocks #1892 (comment)
For ghc >= 9.0 we are losing the haddock errors as warnings, as ghc does not report them directly anymore (for good reasons)
But it is unfortunate that we are losing them as maybe some users find them useful, before they hit the error when building docs.
Maybe we should restore those diagnostics, but not in ghcide, where are not necessary but in the hls-haddock-plugin itself:

https://github.com/haskell/haskell-language-server/blob/master/plugins/hls-haddock-comments-plugin/src/Ide/Plugin/HaddockComments.hs

I would add a option to make them errors or warnings though

jneira added component: haddock plugin type: enhancement labels

jneira closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment