Skip to content

Please add upper bound ghcide <1.5.0.1 to hls-eval-plugin 1.2.0.1 on hackage #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hamishmack opened this issue Nov 25, 2021 · 5 comments
Closed
Labels
old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@hamishmack
Copy link

The latest ghcide in hackage (1.5.0.1) includes this change (when compared to ghcide 1.5.0):

 data GhcSessionDepsConfig = GhcSessionDepsConfig
     { checkForImportCycles :: Bool
-    , forceLinkables       :: Bool
     , fullModSummary       :: Bool
     }
 instance Default GhcSessionDepsConfig where
   def = GhcSessionDepsConfig
     { checkForImportCycles = True
-    , forceLinkables = False
     , fullModSummary = False
     }

It leads to this error when building hls-eval-plugin 1.2.0.1:

[8 of 9] Compiling Ide.Plugin.Eval.CodeLens ( src/Ide/Plugin/Eval/CodeLens.hs, dist/build/Ide/Plugin/Eval/CodeLens.o, dist/build/Ide/Plugin/Eval/CodeLens.dyn_o )

src/Ide/Plugin/Eval/CodeLens.hs:543:15: error:
    ‘forceLinkables’ is not a (visible) constructor field name
    |
543 |             { forceLinkables = True
    |               ^^^^^^^^^^^^^^
@jneira jneira added old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Nov 25, 2021
@jneira
Copy link
Member

jneira commented Nov 25, 2021

So the version bump should have been a breaking one (1.6.0) following pvp.
Will revise the plugin bounds in hackage and change it in the repo

@jneira
Copy link
Member

jneira commented Nov 25, 2021

@jneira
Copy link
Member

jneira commented Nov 25, 2021

Change in the repo done with 484d101 (#2393), thanks for reporting the issue!

@jneira jneira closed this as completed Nov 25, 2021
@jneira jneira mentioned this issue Nov 25, 2021
@pepeiborra
Copy link
Collaborator

My bad

@jneira
Copy link
Member

jneira commented Nov 25, 2021

Dont worry, we should add policeman to the hackage workflow (and remember to use the workflow in check mode even for manual uploads)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

3 participants