Skip to content

Add option to disable import popup notification #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scarf005 opened this issue Sep 21, 2022 · 9 comments
Open

Add option to disable import popup notification #3208

scarf005 opened this issue Sep 21, 2022 · 9 comments
Labels
status: blocked Not actionable, because blocked by upstream/GHC etc.

Comments

@scarf005
Copy link

Is your feature request related to a problem? Please describe.

Everytime I auto-import, a notification pops up. I have to remove it manually using ESC, and it's quite tedius.

Describe the solution you'd like

Add an extension option to disable import popup notification.

Describe alternatives you've considered
tried to find an option to turn this off in extension settings but couldn't find any

Additional context

image
notification in question

@fendor
Copy link
Collaborator

fendor commented Sep 21, 2022

Hi, thank you for your bug-report! I think we need to move this issue to HLS main repo, as this message is sent from it... Unless we can filter it in the client somehow. Moving issue, s.t. we have more eyes on it.

@fendor fendor pinned this issue Sep 21, 2022
@fendor fendor unpinned this issue Sep 21, 2022
@fendor fendor transferred this issue from haskell/vscode-haskell Sep 21, 2022
@michaelpj
Copy link
Collaborator

I'm a bit confused about where this is coming from? Any vscode users who can see from the logs what's causing this?

@fendor
Copy link
Collaborator

fendor commented Sep 21, 2022

Hm, maybe it is indeed a built-in feature from vscode?

@fendor
Copy link
Collaborator

fendor commented Sep 21, 2022

@michaelpj
Copy link
Collaborator

Looks like it's been there for a long time, introduced here: #1371

Apparently I objected to it then, and I still do :D We could use AnnotatedTextEdits now, I think.

@pepeiborra
Copy link
Collaborator

Presumably AnnotatedTextEdits would make an HLS option to disable them unnecessary, since the client would be responsible for that right?

@michaelpj
Copy link
Collaborator

I think so, but I haven't actually tested what they look like in clients.

@michaelpj
Copy link
Collaborator

Semantically, it's the right thing from the spec's perspective, I think.

@michaelpj
Copy link
Collaborator

I made an issue for using them more widely: #3210

@michaelpj michaelpj added status: blocked Not actionable, because blocked by upstream/GHC etc. and removed status: needs triage labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Not actionable, because blocked by upstream/GHC etc.
Projects
None yet
Development

No branches or pull requests

4 participants