Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textDocument/semanticTokens/full/delta #4072

Closed
Tracked by #3931
soulomoon opened this issue Feb 13, 2024 · 0 comments · Fixed by #4073
Closed
Tracked by #3931

textDocument/semanticTokens/full/delta #4072

soulomoon opened this issue Feb 13, 2024 · 0 comments · Fixed by #4073

Comments

@soulomoon
Copy link
Collaborator

soulomoon commented Feb 13, 2024

To suppport textDocument/semanticTokens/full/delta,
Several things need to be taken care of.

  • Use the cache in the shake usesWithStale or create new dedicated cache for semantic tokens
    • we need a dedicated cache, since stale corresponding to the last successful computation, and what we need is the last successful response. (since range in successful computation might be edited by possitional mappings to generate a successful response)
      • new entry in ShakeExtras, semanticTokens :: STM.Map NormalizedUri SemanticTokens
  • Assign a new id to each response of semantic tokens.
    • new entry in ShakeExtras, semanticTokensId :: TVar Int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant