globally: eliminate or mark unused bindings; convert one to dynamic

Author: deepfire

haskell-cabal.el

@@ -460,8 +460,7 @@ resultung buffer-content"
             (,beg (plist-get ,section :beginning))
             (,end (plist-get  ,section :end))
             (,start-col (plist-get  ,section :data-start-column))
-            (,section-data (buffer-substring ,beg ,end))
-            (section-name (plist-get ,section :name )))
+            (,section-data (buffer-substring ,beg ,end)))
        (save-excursion
          (prog1
              (with-temp-buffer
@@ -535,8 +534,7 @@ resultung buffer-content"
   "Strip indentation from each line, execute FORMS and reinstate indentation
    so that the indentation of the FIRST LINE matches"
   (let ((old-l1-indent (make-symbol "new-l1-indent"))
-        (new-l1-indent (make-symbol "old-l1-indent"))
-        (res nil))
+        (new-l1-indent (make-symbol "old-l1-indent")))
     `(let ( (,old-l1-indent (save-excursion
                               (goto-char (point-min))
                               (current-indentation))))
@@ -673,9 +671,9 @@ resultung buffer-content"
   (let ((downcase-name (downcase name)))
     (haskell-cabal-find-subsection-by
      section
-     '(lambda (subsection)
+     `(lambda (subsection)
         (string= (downcase (haskell-cabal-section-name subsection))
-                 downcase-name)))))
+                 ,downcase-name)))))
 
 (defun haskell-cabal-goto-subsection (name)
   (let ((subsection (haskell-cabal-find-subsection (haskell-cabal-section) name)))
@@ -808,7 +806,6 @@ Source names from main-is and c-sources sections are left untouched
         (if (null candidates)
             (let* ((src-dir (haskell-cabal-join-paths base-dir (or (car src-dirs) "")))
                    (newfile (haskell-cabal-join-paths src-dir filename))
-                   (subdir (file-name-directory newfile))
                    (do-create-p (y-or-n-p (format "Create file %s ?" newfile))))
               (when do-create-p
                 (find-file-other-window newfile )))

haskell-checkers.el

@@ -129,13 +129,13 @@
           (when (re-search-forward new-old-code eline t)
             (replace-match new-code nil t)))))))
 
-(defun haskell-lint-finish-hook (buf msg)
+(defun haskell-lint-finish-hook (_buf _msg)
   "Function, that is executed at the end of HLint or scan execution"
   (if haskell-checkers-replace-with-suggestions
       (haskell-lint-replace-suggestions)
     (next-error 1 t)))
 
-(defun haskell-scan-finish-hook (buf msg)
+(defun haskell-scan-finish-hook (_buf _msg)
   "Function, that is executed at the end of haskell-scan execution"
   (next-error 1 t))
 

haskell-commands.el

@@ -344,7 +344,7 @@ should be inserted."
           expr))))))
 
 ;;;###autoload
-(defun haskell-mode-jump-to-def-or-tag (&optional next-p)
+(defun haskell-mode-jump-to-def-or-tag (&optional _next-p)
   ;; FIXME NEXT-P arg is not used
   "Jump to the definition.
 Jump to definition of identifier at point by consulting GHCi, or
@@ -514,7 +514,7 @@ Requires the :loc-at command from GHCi."
                              'face 'compilation-error)))))))
 
 ;;;###autoload
-(defun haskell-process-cd (&optional not-interactive)
+(defun haskell-process-cd (&optional _not-interactive)
   ;; FIXME optional arg is not used
   "Change directory."
   (interactive)
@@ -586,7 +586,7 @@ Query PROCESS to `:cd` to directory DIR."
              (if (string-match "^[A-Za-z_]" (cdr state))
                  (format ":info %s" (cdr state))
                (format ":info (%s)" (cdr state)))))
-      :complete (lambda (state response)
+      :complete (lambda (_state response)
                   (unless (or (string-match "^Top level" response)
                               (string-match "^<interactive>" response))
                     (haskell-mode-message-line response)))))))
@@ -604,7 +604,7 @@ Query PROCESS to `:cd` to directory DIR."
              (if (string-match "^[A-Za-z_]" (cdr state))
                  (format ":type %s" (cdr state))
                (format ":type (%s)" (cdr state)))))
-      :complete (lambda (state response)
+      :complete (lambda (_state response)
                   (unless (or (string-match "^Top level" response)
                               (string-match "^<interactive>" response))
                     (haskell-mode-message-line response)))))))
@@ -720,7 +720,7 @@ function `xref-find-definitions' after new table was generated."
                         (haskell-process-session (car state)))
                        "find . -name '*.hs' -print0 -or -name '*.lhs' -print0 -or -name '*.hsc' -print0"
                        "xargs -0 hasktags -e -x"))))
-      :complete (lambda (state response)
+      :complete (lambda (state _response)
                   (when (cdr state)
                     (let ((session-tags
                           (haskell-session-tags-filename
@@ -803,9 +803,9 @@ output.  If CMD fails the buffer remains unchanged."
                   (while (string-match "\\`\n+\\|^\\s-+\\|\\s-+$\\|\n+\\'" str)
                     (setq str (replace-match "" t t str)))
                   str))
-         (errout (lambda (fmt &rest args)
-                   (let* ((warning-fill-prefix "    "))
-                     (display-warning cmd (apply 'format fmt args) :warning))))
+         (_errout (lambda (fmt &rest args)
+		    (let* ((warning-fill-prefix "    "))
+		      (display-warning cmd (apply 'format fmt args) :warning))))
          (filename (buffer-file-name (current-buffer)))
          (cmd-prefix (replace-regexp-in-string " .*" "" cmd))
          (tmp-file (make-temp-file cmd-prefix))
@@ -814,9 +814,9 @@ output.  If CMD fails the buffer remains unchanged."
                                      haskell-session)
                                 (haskell-session-cabal-dir haskell-session)
                               default-directory))
-         (errcode (with-temp-file tmp-file
-                    (call-process cmd filename
-                                  (list (current-buffer) err-file) nil)))
+         (_errcode (with-temp-file tmp-file
+		     (call-process cmd filename
+				   (list (current-buffer) err-file) nil)))
          (stderr-output
           (with-temp-buffer
             (insert-file-contents err-file)

haskell-complete-module.el

@@ -36,8 +36,7 @@
 
 (defun haskell-complete-module-read (prompt candidates)
   "Interactively auto-complete from a list of candidates."
-  (let ((continue t)
-        (stack (list))
+  (let ((stack (list))
         (pattern "")
         (result nil))
     (delete-dups candidates)

haskell-debug.el

@@ -557,8 +557,7 @@ Stopped at /home/foo/project/src/x.hs:6:25-36
     (cl-loop for span in history
              do (let ((string (haskell-debug-get-span-string
                                (plist-get span :path)
-                               (plist-get span :span)))
-                      (index (plist-get span :index)))
+                               (plist-get span :span))))
                   (insert (propertize (format "%4d" i)
                                       'face 'haskell-debug-trace-number-face)
                           " "

haskell-doc.el

@@ -1617,8 +1617,7 @@ the haskell-doc database."
           (is-reserved (haskell-doc-is-of sym haskell-doc-reserved-ids))
           (is-prelude  (haskell-doc-is-of sym haskell-doc-prelude-types))
           (is-strategy (haskell-doc-is-of sym haskell-doc-strategy-ids))
-          (is-user-defined (haskell-doc-is-of sym haskell-doc-user-defined-ids))
-          (is-prelude  (haskell-doc-is-of sym haskell-doc-prelude-types)))
+          (is-user-defined (haskell-doc-is-of sym haskell-doc-user-defined-ids)))
       (cond
        ;; if reserved id (i.e. Haskell keyword
        ((and haskell-doc-show-reserved

haskell-indent.el

@@ -441,7 +441,7 @@ Returns the location of the start of the comment, nil otherwise."
 
 (defun haskell-indent-next-symbol-safe (end)
   "Puts point to the next following symbol, or to end if there are no more symbols in the sexp."
-  (condition-case errlist (haskell-indent-next-symbol end)
+  (condition-case _errlist (haskell-indent-next-symbol end)
     (error (goto-char end))))
 
 (defun haskell-indent-separate-valdef (start end)
@@ -1303,7 +1303,7 @@ We stay in the cycle as long as the TAB key is pressed."
         (if marker
             (goto-char (marker-position marker)))))))
 
-(defun haskell-indent-region (start end)
+(defun haskell-indent-region (_start _end)
   (error "Auto-reindentation of a region is not supported"))
 
 ;;; alignment functions
@@ -1441,7 +1441,7 @@ TYPE is either 'guard or 'rhs."
             (if regstack
                 (haskell-indent-shift-columns maxcol regstack)))))))
 
-(defun haskell-indent-align-guards-and-rhs (start end)
+(defun haskell-indent-align-guards-and-rhs (_start _end)
   "Align the guards and rhs of functions in the region, which must be active."
   ;; The `start' and `end' args are dummys right now: they're just there so
   ;; we can use the "r" interactive spec which properly signals an error.

haskell-indentation.el

@@ -204,8 +204,7 @@ NIL otherwise."
 
 (defun haskell-indentation-reindent-to (col &optional move)
   "Reindent current line to COL, move the point there if MOVE is non-NIL."
-  (let* ((cc (current-column))
-         (ci (haskell-indentation-current-indentation)))
+  (let* ((ci (haskell-indentation-current-indentation)))
     (save-excursion
       (move-to-column ci)
       (if (<= ci col)
@@ -260,8 +259,7 @@ negative ARG.  Handles bird style literate Haskell too."
   (newline)
   (unless (haskell-indentation-bird-outside-code-p)
     (catch 'parse-error
-      (let* ((cc (current-column))
-             (ci (haskell-indentation-current-indentation))
+      (let* ((ci (haskell-indentation-current-indentation))
              (indentations (haskell-indentation-find-indentations-safe)))
         (when (haskell-indentation-bird-p)
           (insert "> "))
@@ -350,8 +348,7 @@ indentation points to the right, we switch going to the left."
    ((and (eq last-command 'indent-for-tab-command)
          (memq haskell-indentation-dyn-last-direction '(left right))
          haskell-indentation-dyn-last-indentations)
-    (let* ((cc (current-column))
-           (ci (haskell-indentation-current-indentation)))
+    (let ((ci (haskell-indentation-current-indentation)))
       (if (eq haskell-indentation-dyn-last-direction 'left)
           (haskell-indentation-reindent-to
            (haskell-indentation-previous-indentation

haskell-interactive-mode.el

@@ -206,7 +206,7 @@ be nil.")
 
 ;; (define-key haskell-error-mode-map (kbd "q") 'quit-window)
 
-(defun haskell-interactive-mode-handle-h (&optional bound)
+(defun haskell-interactive-mode-handle-h ()
   "Handle ^H in output."
   (let ((bound (point-min))
         (inhibit-read-only t))
@@ -252,9 +252,7 @@ do the
       expr
     (let* ((i 0)
            (lines (split-string expr "\n"))
-           (len (length lines))
-           (indent (make-string (length haskell-interactive-prompt)
-                                ? )))
+           (len (length lines)))
       (mapconcat 'identity
                  (cl-loop for line in lines
                           collect (cond ((= i 0)
@@ -330,15 +328,14 @@ SESSION, otherwise operate on the current buffer.
   "Insert the result of an eval as plain text."
   (with-current-buffer (haskell-session-interactive-buffer session)
     (goto-char (point-max))
-    (let ((start (point)))
-      (insert (ansi-color-apply
-               (propertize text
-                           'font-lock-face 'haskell-interactive-face-result
-                           'rear-nonsticky t
-                           'read-only t
-                           'prompt t
-                           'result t)))
-      (haskell-interactive-mode-handle-h start))
+    (insert (ansi-color-apply
+	     (propertize text
+			 'font-lock-face 'haskell-interactive-face-result
+			 'rear-nonsticky t
+			 'read-only t
+			 'prompt t
+			 'result t)))
+    (haskell-interactive-mode-handle-h)
     (let ((marker (set (make-local-variable 'haskell-interactive-mode-result-end)
                        (make-marker))))
       (set-marker marker
@@ -572,8 +569,7 @@ FILE-NAME only."
 
 (defun haskell-process-suggest-remove-import (session file import line)
   "Suggest removing or commenting out IMPORT on LINE."
-  (let ((continue t)
-        (first t))
+  (let ((first t))
     (cl-case (read-event
               (propertize (format "%sThe import line `%s' is redundant. Remove? (y, n, c: comment out)  "
                                   (if (not first)
@@ -813,7 +809,6 @@ FILE-NAME only."
   "Insert the presentation, hooking up buttons for each slot."
   (let* ((rep (cadr (assoc 'rep presentation)))
          (text (cadr (assoc 'text presentation)))
-         (type (cadr (assoc 'type presentation)))
          (slots (cadr (assoc 'slots presentation)))
          (nullary (null slots)))
     (cond
@@ -1006,7 +1001,6 @@ don't care when the thing completes as long as it's soonish."
   "Offer completions for partial expression between prompt and point"
   (when (haskell-interactive-at-prompt)
     (let* ((process (haskell-interactive-process))
-           (session (haskell-interactive-session))
            (inp (haskell-interactive-mode-input-partial)))
       (if (string= inp (car-safe haskell-interactive-mode-completion-cache))
           (cdr haskell-interactive-mode-completion-cache)

haskell-menu.el

@@ -65,7 +65,7 @@ Letters do not insert themselves; instead, they are commands."
 (define-key haskell-menu-mode-map (kbd "p") 'previous-line)
 (define-key haskell-menu-mode-map (kbd "RET") 'haskell-menu-mode-ret)
 
-(defun haskell-menu-revert-function (arg1 arg2)
+(defun haskell-menu-revert-function (_arg1 _arg2)
   "Function to refresh the display."
   (let ((buffer-read-only nil)
         (orig-line (line-number-at-pos))