Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pre-release/update notifications through an environment variable #4096

Open
jflambert opened this issue Mar 12, 2020 · 3 comments
Open
Assignees
Labels
c/server Related to server k/enhancement New feature or improve an existing feature

Comments

@jflambert
Copy link
Contributor

I want to be able to immediately "opt-out" (as it's called in 1.1.0) from pre-release notifications, as well as any upgrade notification, through an environment variable similar to HASURA_GRAPHQL_ENABLE_TELEMETRY. Basically I don't want to see the popups in the console.

I don't think one exists.

@tirumaraiselvan tirumaraiselvan added the support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog label Mar 22, 2020
@rikinsk rikinsk added c/server Related to server c/console Related to console e/easy can be wrapped up in a couple of days p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints k/enhancement New feature or improve an existing feature and removed c/server Related to server support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog labels Mar 23, 2020
@rikinsk rikinsk removed their assignment Mar 23, 2020
@rikinsk
Copy link
Member

rikinsk commented Mar 23, 2020

This can be solved in 2 ways:

The console can allow users to opt-out of all notifications. The notification will be shown once after which it wont be shown again for that db instance.

The server can take an ENV variable as suggested here and pass it to the console. The notification will never be shown.

Leaving this issue open for the server based solution. Created #4165 for the console only solution

@rikinsk rikinsk added c/server Related to server and removed e/easy can be wrapped up in a couple of days p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Mar 23, 2020
@jflambert
Copy link
Contributor Author

@rikinsk I'd really prefer an env var ;) but thanks

@jflambert
Copy link
Contributor Author

I'm waiting for confirmation from a team mate but I was told that Hasura will crash hard when it runs in an offline environment -- because it tries to contact github.com to check for an update?

Which makes this issue even more important to fix IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Related to server k/enhancement New feature or improve an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants