Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Authentication Headers example to avoid security flaws #147

Open
slax57 opened this issue Feb 1, 2023 · 0 comments
Open

Improve the Authentication Headers example to avoid security flaws #147

slax57 opened this issue Feb 1, 2023 · 0 comments

Comments

@slax57
Copy link

slax57 commented Feb 1, 2023

It seems to me that the Adding Authentication Headers section is very misleading in the way it suggests to implement authentication.

It encourages to pass the hasura admin secret as the x-hasura-admin-secret http header, but this should be kept for early developing stages only.
If ever such code gets deployed to production, then basically the hasura admin secret will be embedded in the (client-side) JS code, as well as each HTTP requests.

To me, this doc section should rather encourage providing only the JWT token, or add least add a very highlighted warning note about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant