Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite justfile into bun shell or dax or something #437

Closed
hatoo opened this issue Mar 18, 2024 · 0 comments · Fixed by #446
Closed

Rewrite justfile into bun shell or dax or something #437

hatoo opened this issue Mar 18, 2024 · 0 comments · Fixed by #446

Comments

@hatoo
Copy link
Owner

hatoo commented Mar 18, 2024

oha/justfile

Lines 1 to 20 in 64b6a98

[unix]
pgo addtional-args="":
#!/bin/bash
# Disable trap in CI
# `just` returns weired exit code if we use trap
if [ -z $CI]; then trap "kill 0" EXIT; fi
cargo run --release --manifest-path pgo/server/Cargo.toml &
# Should be more than 1m
cargo pgo run -- --profile pgo {{addtional-args}} -- -z 3m -c 900 --no-tui http://localhost:8888
cargo pgo optimize build -- --profile pgo {{addtional-args}}
set windows-powershell := true
[windows]
pgo addtional-args="":
try { \
$proc = Start-Process -NoNewWindow -PassThru cargo -ArgumentList 'run','--release','--manifest-path','pgo/server/Cargo.toml'; \
cargo pgo run -- --profile pgo {{addtional-args}} -- -z 3m -c 900 --no-tui http://localhost:8888; \
cargo pgo optimize build -- --profile pgo {{addtional-args}}; \
} finally { Stop-Process -Id $proc.Id }

Currently, justfile is bad due to supporting the Corss platform.

I think it's good to rewrite it to a more cross-platform shell, like bun shell or dax or something.
I don't know which is better though.

@hatoo hatoo mentioned this issue Apr 2, 2024
@hatoo hatoo closed this as completed in #446 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant