Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of Reference Software #20

Open
haudiobe opened this issue Jul 27, 2021 · 2 comments
Open

Version of Reference Software #20

haudiobe opened this issue Jul 27, 2021 · 2 comments
Assignees

Comments

@haudiobe
Copy link
Owner

We have a reference software that is different for different scenarios. For example S3 uses HM16.22 whereas S2 uses HM16.23. The streams.csv is clear about this. We should add this.

@haudiobe haudiobe assigned haudiobe and nlsdvl and unassigned haudiobe Jul 27, 2021
@nlsdvl
Copy link
Collaborator

nlsdvl commented Jul 29, 2021

The scripts are not checking with the encoder version directly. The current behavior, for all encoders, is :

Both HM16.22 and HM16.23 result in the 'HM' encoder id being used. The HM encoder executable path are configured through environment path.

When building the docker image, the HM version can be specified at build time with the docker build --build-arg. In that case, it is recommended to tag the docker image with the version used.
for instance:

docker build --build-arg HM_VERSION=tags/HM-16.23 -t anchortools:hm1623 -f ./docker/Dockerfile .

then when running the image, specify the tag that matches the version you want.

@nlsdvl
Copy link
Collaborator

nlsdvl commented Aug 1, 2021

README has been updated to show how to build docker images with specifc versions for a given scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants