Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Monaco Uri class to use System.Uri or Windows.Foundation.Uri #33

Open
hawkerm opened this issue Mar 28, 2020 · 3 comments
Open

Comments

@hawkerm
Copy link
Owner

hawkerm commented Mar 28, 2020

Not sure which of the two .NET Uri classes makes more sense to use, but I think they both support the pieces needed to do a nice JsonConverter to make it easier to use the API in .NET.

@hawkerm
Copy link
Owner Author

hawkerm commented Mar 29, 2020

We did use System.Uri already for the CssGlyphStyle here:

public System.Uri GlyphImage { get; set; }

@hawkerm
Copy link
Owner Author

hawkerm commented Jul 29, 2021

Not sure if there's other places, but for the Monaco Model Uri, there's a different problem, filed here #59.

@hawkerm hawkerm removed this from the v0.9-beta milestone Aug 15, 2021
@hawkerm
Copy link
Owner Author

hawkerm commented Aug 15, 2021

Yeah, the Monaco Uri is special for a couple of things, so not sure if this makes sense in some spots. Need to think about this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant