Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Pass paramaters into a new span in #[trace] macro. #53

Open
davidbarsky opened this issue Oct 29, 2018 · 0 comments
Open

Pass paramaters into a new span in #[trace] macro. #53

davidbarsky opened this issue Oct 29, 2018 · 0 comments
Labels
area/macros Related to macros crate/macros Related to the `tokio-trace-macros` crate kind/enhancement New feature or request

Comments

@davidbarsky
Copy link
Collaborator

As @hawkw said on #16:

For future work: it would be really cool if we could pass all the params to the function as fields here as well.

Since some parameters may not be valid span fields, we might consider adding an additional attribute (#[trace_ignore]?) to annotate those fields that should be skipped.
@davidbarsky davidbarsky added the kind/enhancement New feature or request label Oct 29, 2018
@davidbarsky davidbarsky changed the title Pass paramater into a new span in #[trace] macro. Pass paramaters into a new span in #[trace] macro. Oct 29, 2018
@davidbarsky davidbarsky mentioned this issue Oct 29, 2018
Merged
@hawkw hawkw added the crate/macros Related to the `tokio-trace-macros` crate label Nov 5, 2018
@hawkw hawkw added the area/macros Related to macros label Nov 30, 2018
@hawkw hawkw mentioned this issue Feb 8, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/macros Related to macros crate/macros Related to the `tokio-trace-macros` crate kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidbarsky @hawkw