Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support #1

Closed
cmandlbaur opened this issue Sep 5, 2017 · 3 comments
Closed

Windows Support #1

cmandlbaur opened this issue Sep 5, 2017 · 3 comments

Comments

@cmandlbaur
Copy link

cmandlbaur commented Sep 5, 2017

Just an FYI on Windows support status.

Command prompt - Not functional
Powershell - Not functional
cmder/ConEmu - Pretty good
git bash - Throws an error whilst running through the tests, but has basic colour support.

virtualbox_testo_05_09_2017_23_38_43
virtualbox_testo_05_09_2017_23_39_03
virtualbox_testo_05_09_2017_23_39_25
virtualbox_testo_05_09_2017_23_39_42

Happy to test

@haxiomic
Copy link
Owner

haxiomic commented Sep 5, 2017

Hey Chris,

Thanks for taking the time to test! These are really interesting results

Command Prompt - wow that's a mess! Historically it has had no color support out of the box, more recently in Windows 10 it can now support the same color codes that mac and linux terminals use but it needs to be enabled, which I might be able to do within the library. Nevertheless, when formatting isn't supported in the console it shouldn't print all the junk!

Powershell - It looks like there's a trick to this, so we should be able to support this

Cmder - This one is nearly there, looks like utf-8 isn't enabled out of the box but there's a command to enable it. It also looks to be limited to 16 colors rather than 256, I think there's an option to enable 256 in the settings but probably nothing that can be done by the program itself

Git Bash - Pretty close, however the "Error: something went wrong" printed at the bottom of the git bash test is curious because it should have been printed above "Success!"

I'm going to get a Windows VM going this week and see what can be done

Here's how I expect it to look (at least with my terminal color scheme)
expected

@haxiomic
Copy link
Owner

Hey @cmandlbaur, try again with the latest changes - colored output (with correct utf-8 charset) should work in Command Prompt and others for the C++ and Neko targets. The caveat is that it requires a fairly up-to-date version of Windows 10

colorful cmd

@cmandlbaur
Copy link
Author

Will try when I get a gap, just trying to wrap some things up and then will be traveling to the summit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants