Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the default number of retries to 3 and add error logging #107

Closed
leszko opened this issue Sep 27, 2019 · 4 comments
Closed

Reduce the default number of retries to 3 and add error logging #107

leszko opened this issue Sep 27, 2019 · 4 comments
Milestone

Comments

@leszko
Copy link

leszko commented Sep 27, 2019

No description provided.

@leszko leszko changed the title Make the retry number configurable and reduce the default value to 3 Make the retry number configurable, reduce the default value to 3, and add error logging Sep 27, 2019
@leszko leszko changed the title Make the retry number configurable, reduce the default value to 3, and add error logging Reduce the default number of retries to 3 and add error logging Sep 27, 2019
@leszko leszko added this to the 3.1 milestone Jan 9, 2020
@alparslanavci
Copy link
Contributor

@leszko, there is an existing error logging in RetryUtils: https://github.com/alparslanavci/hazelcast-aws/blob/master/src/main/java/com/hazelcast/aws/utility/RetryUtils.java#L59

Do you mean anywhere else?

@leszko
Copy link
Author

leszko commented Jan 13, 2020

The behavior should be that in case of an error, calls to AWS REST API are retries 3 times and then the error from AWS REST API is printed to the user. If you checked that's the behavior, then that's all we need :)

@alparslanavci
Copy link
Contributor

alparslanavci commented Jan 13, 2020

Yes, it is escalating the error from AWS REST API to the user at the end of retries. I will update the default number of retries with a commit. Closing this issue now.

@alparslanavci
Copy link
Contributor

See 490bc3b for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants