Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of icons when the test is highlighted/selected #90

Open
vladimir-djokic opened this issue Aug 12, 2019 · 5 comments
Open

Visibility of icons when the test is highlighted/selected #90

vladimir-djokic opened this issue Aug 12, 2019 · 5 comments

Comments

@vladimir-djokic
Copy link

This is a nitpick from me, but when using Light+ theme in VSCode, visibility of icons for selected test is not good, as in screenshot:

Annotation 2019-08-12 143428

If they would become white (as does the text), then they would be much easier to view.

@hacknug
Copy link

hacknug commented Aug 12, 2019

I'd say they should use the same dark grey those icons on the right. UI-wise that's what the whole app does.

@hbenl
Copy link
Owner

hbenl commented Aug 12, 2019

It would be nice if the icons could change color like the text does. Unfortunately, I don't see how I could do this, the API doesn't allow me to specify different icons for the selected element. Looking at other extensions and even built-in icons in the VS Code UI, they all remain dark even when the background becomes dark because the element was selected.

@hbenl hbenl closed this as completed Aug 12, 2019
@vladimir-djokic
Copy link
Author

vladimir-djokic commented Sep 2, 2019

@hbenl I do not believe that this should have been closed so eagerly. This issue can be resolved, as demonstrated in the screenshot:

Annotation 2019-09-02 174001

What you can observe in the screenshot is the white outline present for he light theme.

Here is the screenshot when using dark theme:

Annotation 2019-09-02 174207

Also note that some of square-in-circle icon (icon in front of the specs) is not the color used by the rest of the icons (as mentioned by @hacknug) so it looks "pale" in both light and dark themes.

@hbenl
Copy link
Owner

hbenl commented Sep 2, 2019

@vladeck Thanks, the white outline is an excellent solution (as your screenshots show).

@numaru
Copy link
Contributor

numaru commented Sep 24, 2019

The vscode team is working on a way to dynamically set the color of the icons and it is in the iteration plan for september. microsoft/vscode#78889 is marked related to microsoft/vscode#55857. Also, there is a good chance to see a new api in the next version of vscode to use theme-able icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants