-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visibility of icons when the test is highlighted/selected #90
Comments
I'd say they should use the same dark grey those icons on the right. UI-wise that's what the whole app does. |
It would be nice if the icons could change color like the text does. Unfortunately, I don't see how I could do this, the API doesn't allow me to specify different icons for the selected element. Looking at other extensions and even built-in icons in the VS Code UI, they all remain dark even when the background becomes dark because the element was selected. |
@hbenl I do not believe that this should have been closed so eagerly. This issue can be resolved, as demonstrated in the screenshot: What you can observe in the screenshot is the white outline present for he light theme. Here is the screenshot when using dark theme: Also note that some of square-in-circle icon (icon in front of the specs) is not the color used by the rest of the icons (as mentioned by @hacknug) so it looks "pale" in both light and dark themes. |
@vladeck Thanks, the white outline is an excellent solution (as your screenshots show). |
The vscode team is working on a way to dynamically set the color of the icons and it is in the iteration plan for september. microsoft/vscode#78889 is marked related to microsoft/vscode#55857. Also, there is a good chance to see a new api in the next version of vscode to use theme-able icons. |
This is a nitpick from me, but when using Light+ theme in VSCode, visibility of icons for selected test is not good, as in screenshot:
If they would become white (as does the text), then they would be much easier to view.
The text was updated successfully, but these errors were encountered: