You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
a) Atm the GENERATE_TESTDATA is hard coded to true. The default should be false.
The effect is that no real test is done, i.e. no comparison (aka diff) between the generated resources and the commited test resources is done => All build will always be successful.
b) the diffing in test seems to fail when the order of keys is not the expected one. The order should not matter:
[ERROR] AlmaMarc21XmlToLobidJsonTest.transformFiles:137->lambda$transformFiles$1:174 expected:<... "publishedBy" : "S[emiconductor Media Ltd. Trans World House",
"startDate" : "20092011]",
"type" : [ "P...> but was:<... "publishedBy" : "S[olar Media Ltd., Trans-World House",
"startDate" : "20092011",
"type" : [ "PublicationEvent" ],
"location" : "London",
"publishedBy" : "Semiconductor Media Ltd. Trans World House]",
"type" : [ "P...>
The text was updated successfully, but these errors were encountered:
a) Atm the
GENERATE_TESTDATA
is hard coded totrue
. The default should befalse
.The effect is that no real test is done, i.e. no comparison (aka diff) between the generated resources and the commited test resources is done => All build will always be successful.
b) the diffing in test seems to fail when the order of keys is not the expected one. The order should not matter:
The text was updated successfully, but these errors were encountered: