Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #1124

Closed
dr0i opened this issue Feb 16, 2021 · 2 comments
Closed

Fix tests #1124

dr0i opened this issue Feb 16, 2021 · 2 comments
Assignees
Milestone

Comments

@dr0i
Copy link
Member

dr0i commented Feb 16, 2021

a) Atm the GENERATE_TESTDATA is hard coded to true. The default should be false.
The effect is that no real test is done, i.e. no comparison (aka diff) between the generated resources and the commited test resources is done => All build will always be successful.
b) the diffing in test seems to fail when the order of keys is not the expected one. The order should not matter:

[ERROR] AlmaMarc21XmlToLobidJsonTest.transformFiles:137->lambda$transformFiles$1:174 expected:<... "publishedBy" : "S[emiconductor Media Ltd. Trans World House",
"startDate" : "20092011]",
"type" : [ "P...> but was:<... "publishedBy" : "S[olar Media Ltd., Trans-World House",
"startDate" : "20092011",
"type" : [ "PublicationEvent" ],
"location" : "London",
"publishedBy" : "Semiconductor Media Ltd. Trans World House]",
"type" : [ "P...>

@TobiasNx
Copy link
Contributor

TobiasNx commented Oct 4, 2022

@dr0i still an issue?

@dr0i
Copy link
Member Author

dr0i commented Oct 4, 2022

No, can be closed. Closing.

@dr0i dr0i closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants