Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch OPAC URL templates from source file #387

Open
acka47 opened this issue Apr 19, 2017 · 5 comments
Open

Fetch OPAC URL templates from source file #387

acka47 opened this issue Apr 19, 2017 · 5 comments
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Apr 19, 2017

Currently, we replicate the file https://github.com/hbz/link-templates/blob/master/isil2opac_hbzid.json both in this repo and in the lobid-resources repo. As this file needs to be updated quite often, this is impractical. In the future, OPAC URL templates should directly be fetched from GitHub at https://raw.githubusercontent.com/hbz/link-templates/master/isil2opac_hbzid.json. Corresponding issue in lobid-resources is hbz/lobid-resources#397.

@acka47 acka47 modified the milestones: NWBib 2.0, Vorbereitung VDL-Integration Oct 9, 2017
@acka47
Copy link
Contributor Author

acka47 commented Jul 18, 2018

@fsteeg Isn't this already implemented, as well as hbz/lobid-resources#397?

@fsteeg
Copy link
Member

fsteeg commented Jul 19, 2018

Off the top of my head I'd say it's implemented in resources, but not here in NWBib. Will investigate.

@TobiasNx
Copy link
Contributor

Wird unnötig durch #628

Kann ich schließen @fsteeg ?

@TobiasNx
Copy link
Contributor

TobiasNx commented May 8, 2024

Wird unnötig durch #628

Kann ich schließen @fsteeg ?

@acka47 wir können das doch schließen, da wir jetzt für ALMA die OPAC Links anders erzeugen

@fsteeg
Copy link
Member

fsteeg commented May 8, 2024

wir können das doch schließen, da wir jetzt für ALMA die OPAC Links anders erzeugen

Ja, im Prinzip schon, allerdings könnte dann das Template-Zeug auch mal weg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants