Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37 add start script #38

Merged
merged 7 commits into from
May 8, 2020
Merged

37 add start script #38

merged 7 commits into from
May 8, 2020

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Apr 6, 2020

See #37.

Adding start scripts analog to skohub-pubsub (see #37).

Nothing changes BUT:
@literarymachine the port of the production server is no more hardcoded in package.json. Please review if this is OK for you.

dr0i added 2 commits April 6, 2020 11:40
A `npm run serve` will now start on the defualt port 8080 rather than 8081.
Providing a variable `PORT` will start it at that port.

See #37.
- improve logging in start script

See #37.
@dr0i dr0i requested a review from literarymachine April 6, 2020 12:08
@dr0i dr0i self-assigned this Apr 6, 2020
@dr0i dr0i force-pushed the 37-addStartScript branch from a8a3d63 to 6dba3ad Compare April 6, 2020 14:35
@dr0i dr0i merged commit 29aaba2 into master May 8, 2020
@dr0i dr0i deleted the 37-addStartScript branch May 8, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant