Board: 1265: Make Card Actions extensible #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annano
changed the title
Signed-off-by: Anna No <anna.no@xored.com>
BykhovDenis
approved these changes
Apr 7, 2022
| } | ||
| ] | ||
| export const getCardActions = async (client: Client) => { | ||
| return await client.findAll(board.class.CardAction, {}); |
There was a problem hiding this comment.
Why you need this? You can use it directy
| let actionGroups: { label: IntlString; actions: CardAction[] }[] = [] | ||
|
|
||
| getCardActions(client).then((result) => { | ||
| result.forEach(async (action) => { |
There was a problem hiding this comment.
It will not work, because .forEach doesn't await inner func. You should use for of or any another loop and await all promises. Currently sort may work incorrect
BykhovDenis
requested changes
Apr 7, 2022
Signed-off-by: Anna No <anna.no@xored.com>
BykhovDenis
approved these changes
Apr 7, 2022
haiodo
approved these changes
Apr 8, 2022
budaeva
pushed a commit
that referenced
this pull request
Apr 13, 2022
Signed-off-by: Anna No <anna.no@xored.com> Signed-off-by: budaeva <irina.budaeva@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.