Board: Add button shape and title props #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna No <anna.no@xored.com>
haiodo
reviewed
Apr 12, 2022
| @@ -24,14 +24,15 @@ | |||
| export let labelParams: Record<string, any> = {} | |||
| export let kind: 'primary' | 'secondary' | 'no-border' | 'transparent' | 'link' | 'dangerous' = 'secondary' | |||
| export let size: 'small' | 'medium' | 'large' | 'x-large' = 'medium' | |||
| export let shape: 'circle' | undefined | |||
There was a problem hiding this comment.
Suggested change
| export let shape: 'circle' | undefined | |
| export let shape: 'circle' | undefined = undefined |
To prevent warnings for usual use
Signed-off-by: Anna No <anna.no@xored.com>
haiodo
reviewed
Apr 12, 2022
| export let icon: Asset | AnySvelteComponent | undefined = undefined | ||
| export let justify: 'left' | 'center' = 'center' | ||
| export let disabled: boolean = false | ||
| export let loading: boolean = false | ||
| export let width: string | undefined = undefined | ||
| export let resetIconSize: boolean = false | ||
| export let focus: boolean = false | ||
| export let isCircle: boolean = false |
There was a problem hiding this comment.
@annano please also check CircleButton.svelte in @anticrm/ui
haiodo
approved these changes
Apr 12, 2022
budaeva
pushed a commit
that referenced
this pull request
Apr 13, 2022
Signed-off-by: Anna No <anna.no@xored.com> Signed-off-by: budaeva <irina.budaeva@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna No anna.no@xored.com