Board: Fix labels model #1405
Merged
Board: Fix labels model #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
BykhovDenis
approved these changes
Apr 14, 2022
plugins/board/src/index.ts
Outdated
| attachedTo: Ref<Board> | ||
|
|
||
| title: string | ||
| title?: string |
There was a problem hiding this comment.
It really can be undefined?
There was a problem hiding this comment.
Yes, system labels have only color by default, user defined labels may also have texts.
There was a problem hiding this comment.
It will be better to use title: string | null, since we do not support undefined for model fields, because mongo doesn't :-)
There was a problem hiding this comment.
Let's make it not optional and empty if empty/
Signed-off-by: Anna No <anna.no@xored.com>
haiodo
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.