Tracker: move "IssueStatus" enum into model #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 18, 2022 18:00
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
ghost
requested a review
from 
haiodo
requested changes
Apr 19, 2022
added 7 commits
April 20, 2022 12:35
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
reviewed
Apr 21, 2022
haiodo
reviewed
Apr 21, 2022
| @@ -32,6 +32,7 @@ | |||
| "@anticrm/contact": "~0.6.5", | |||
| "@anticrm/chunter": "~0.6.1", | |||
| "@anticrm/attachment": "~0.6.1", | |||
| "@anticrm/task": "~0.6.0" | |||
| "@anticrm/task": "~0.6.0", | |||
| "lexorank": "~1.0.4" | |||
There was a problem hiding this comment.
Why we need it here? I think we should use it from tracker-resources.
There was a problem hiding this comment.
We can't import utils from the tracker-resources because it has some dependencies from @anticrm/tracker. So, I got this error when trying to make rushx upgrade:
/Users/ogs/Projects/Xored/anticrm/plugins/tracker-resources/src/components/issues/Active.svelte:15
<script lang="ts">
^
SyntaxError: Unexpected token '<'
at Object.compileFunction (node:vm:352:18)
added 4 commits
April 22, 2022 15:28
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Also remove "getIssueStatuses" util function Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
approved these changes
Apr 22, 2022
added 3 commits
April 23, 2022 19:32
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com> # Conflicts: # common/config/rush/pnpm-lock.yaml # packages/kanban/src/components/Kanban.svelte # plugins/tracker-resources/src/components/CreateIssue.svelte # plugins/tracker-resources/src/components/StatusSelector.svelte # plugins/tracker-resources/src/components/issues/Active.svelte # plugins/tracker-resources/src/components/issues/Backlog.svelte # plugins/tracker-resources/src/components/issues/Board.svelte # plugins/tracker-resources/src/components/issues/CategoryPresenter.svelte # plugins/tracker-resources/src/components/issues/Issues.svelte # plugins/tracker-resources/src/components/issues/StatusPresenter.svelte # plugins/tracker-resources/src/utils.ts
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1331