Board: fix attribute views for tags #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna No <anna.no@xored.com>
BykhovDenis
approved these changes
Jun 9, 2022
Signed-off-by: Anna No <anna.no@xored.com>
Dvinyanin
reviewed
Jun 9, 2022
| const typeClass = hierarchy.getClass(presenterClass.attrClass) | ||
| const editorMixin = hierarchy.as(typeClass, view.mixin.AttributeEditor) | ||
| editor = getResource(editorMixin.editor).catch((cause) => { | ||
| console.error(`failed to find editor for ${_class} ${attribute} ${presenterClass.attrClass} cause: ${cause}`) | ||
| }) | ||
| } | ||
| if (presenterClass?.attrClass !== undefined && presenterClass?.category === 'array') { | ||
| if (presenterClass.category === 'collection' && allowedCollections.findIndex(attr => attr === attribute?.name) >= 0) { |
There was a problem hiding this comment.
Aren't the collections already filtered by the ClassAttributeBar?
Dvinyanin
reviewed
Jun 9, 2022
| if (presenterClass?.attrClass === undefined) { | ||
| return | ||
| } | ||
| if (presenterClass.category === 'attribute') { |
There was a problem hiding this comment.
Maybe extract mixin type into a variable?
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Signed-off-by: Anna No <anna.no@xored.com>
Dvinyanin
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna No anna.no@xored.com
Contribution checklist
Brief description
Checklist
Related issues
A list of closed updated issues