Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags: Add inline editor #2081

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Tags: Add inline editor #2081

merged 4 commits into from
Jun 15, 2022

Conversation

annano
Copy link
Contributor

@annano annano commented Jun 15, 2022 •
edited
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

annano added 4 commits June 15, 2022 18:58
@annano
Tags: Revert collection editor changes
f8bb81d 
Signed-off-by: Anna No <anna.no@xored.com>
@annano
Tags: Revert collection editor changes
d4fd685 
Signed-off-by: Anna No <anna.no@xored.com>
@annano
Attribute editor: add inlineEditor
f962fea 
Signed-off-by: Anna No <anna.no@xored.com>
@annano
Merge remote-tracking branch 'origin/main' into ano/fix-tags-collecti…
5adcf0d 
…on-editor

# Conflicts:
#	models/tags/src/index.ts
#	packages/presentation/src/components/AttributeBarEditor.svelte
@annano annano mentioned this pull request Jun 15, 2022
Closed
13 tasks
@haiodo haiodo merged commit e732568 into main Jun 15, 2022
@haiodo haiodo deleted the ano/fix-tags-collection-editor branch June 15, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

@haiodo haiodo haiodo approved these changes

@Dvinyanin Dvinyanin Awaiting requested review from Dvinyanin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annano @haiodo @BykhovDenis