Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker: labels on the card. #2221

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Tracker: labels on the card. #2221

merged 1 commit into from
Jul 7, 2022

Conversation

SasLord
Copy link
Member

@SasLord SasLord commented Jul 6, 2022 •
edited by huly-github-staging bot
Loading

Signed-off-by: Alexander Platov sas_lord@mail.ru

Contribution checklist

Brief description

Снимок экрана 2022-07-07 в 00 46 19 Снимок экрана 2022-07-07 в 00 43 25

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues TSK-244

View in Huly UBERF-1651

@SasLord
Tracker: labels on the card.
d3876e8 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
haiodo
haiodo reviewed Jul 7, 2022
View reviewed changes
plugins/tracker-resources/src/components/issues/KanbanView.svelte
@@ -146,6 +157,8 @@
return []
}
$: states = getIssueStates(groupBy, shouldShowEmptyGroups, issueStates, issueStatusStates, priorityStates)

const fullFilled: { [key: string]: boolean } = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be cleared on issue list update, in case of deleted items.

@haiodo haiodo merged commit 2450fd0 into main Jul 7, 2022
@haiodo haiodo deleted the kanban-labels branch July 7, 2022 02:21
mrsadman99 added a commit that referenced this pull request Jul 7, 2022
@mrsadman99
Merge branch 'main' into TSK-268
5b92e7f 
* main:
  Tracker: labels on the card. (#2221)
  Fixing few issues. (#2220)
  Fixed rendering of the right sidebar (#2219)
  Update issue status colors (#2218)
  Show workspace name rules (#2217)
  Fix few issues (#2216)
  Workspace in url (#2214)
  Remove completed and canceled issues from the list (#2213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SasLord @haiodo