Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker: Refactor ViewOptions #2228

Merged
merged 4 commits into from
Jul 10, 2022
Merged

Tracker: Refactor ViewOptions #2228

merged 4 commits into from
Jul 10, 2022

Conversation

Dvinyanin
Copy link
Contributor

@Dvinyanin Dvinyanin commented Jul 8, 2022 •
edited
Loading

Signed-off-by: Dvinyanin Alexandr dvinyanin.alexandr@gmail.com

Contribution checklist

Brief description

Screenshot from 2022-07-08 10-28-11

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues
https://front.hc.engineering/workbench/platform/tracker/TSK-262

@Dvinyanin
Refactor ViewOptions
fa01c92 
Signed-off-by: Dvinyanin Alexandr <dvinyanin.alexandr@gmail.com>
@Dvinyanin Dvinyanin requested a review from haiodo July 8, 2022 03:43
Dvinyanin added 3 commits July 10, 2022 21:50
@Dvinyanin
Fix store usage
d6d73a9 
Signed-off-by: Dvinyanin Alexandr <dvinyanin.alexandr@gmail.com>
@Dvinyanin
Merge branch 'main' into feature-262
501507c 
Signed-off-by: Dvinyanin Alexandr <dvinyanin.alexandr@gmail.com>
@Dvinyanin
fix format
4c66365 
Signed-off-by: Dvinyanin Alexandr <dvinyanin.alexandr@gmail.com>
@haiodo haiodo merged commit 39b0cbd into main Jul 10, 2022
@haiodo haiodo deleted the feature-262 branch July 10, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dvinyanin @haiodo