Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-421: Improve Core testing and coverage #2387

Merged
merged 5 commits into from
Nov 23, 2022
Merged

TSK-421: Improve Core testing and coverage #2387

merged 5 commits into from
Nov 23, 2022

Conversation

disant1
Copy link
Contributor

@disant1 disant1 commented Nov 21, 2022 •
edited
Loading

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@disant1 disant1 marked this pull request as draft November 21, 2022 06:51
@disant1 disant1 requested a review from haiodo November 21, 2022 10:43
@disant1 disant1 requested a review from haiodo November 22, 2022 02:44
@disant1 disant1 changed the title TSK-421: Improve coverage for clients.ts TSK-421: Improve Core testing and coverage Nov 22, 2022
@disant1 disant1 marked this pull request as ready for review November 23, 2022 02:19
@disant1
Improve coverage for clients.ts
c9ae1b9 
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1
Refactor and fix comments
d74cb5a 
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1
Fix typo
f93aef9 
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1
Fix formatting
8f8bd91 
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1
Added 2 tests for hierarchy.ts
ebba23e 
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1 disant1 merged commit 2238986 into hcengineering:main Nov 23, 2022
@disant1 disant1 deleted the tsk-421-improve-core-test-coverage branch November 24, 2022 02:04
mrsadman99 pushed a commit that referenced this pull request Nov 24, 2022
Merge branch 'main' into TSK-418
fcd45d1 
* main:
  TSK-397: Fixed time report round (#2389)
  TSK-421: Improve Core testing and coverage (#2387)
  Fixes to collaborator and documents (#2394)
  Add sprint members (#2392)
  TSK-420: Fixed time report placeholders (#2390)
  HR: Update Schedule layout. Fix tooltip and popup. (#2388)
  TSK-433 Allow to send attachments without text

Signed-off-by: Anton Brechka <anton.brechka@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disant1 @haiodo