Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-360: Assignee selection enhancements #2509

Merged
merged 10 commits into from
Jan 19, 2023

Conversation

disant1
Copy link
Contributor

@disant1 disant1 commented Jan 16, 2023

Signed-off-by: Denis Maslennikov denis.maslennikov@gmail.com

Contribution checklist

Brief description

Screenshot 2023-01-16 at 20 56 01

Screenshot 2023-01-16 at 20 56 25

Screenshot 2023-01-16 at 20 56 33

Checklist

  • - UI test added to added/changed functionality?

  • - Screenshot is added to PR if applicable ?

  • - Does the code work? Check whether function and logic are correct.

  • - Does Changelog.md is updated with changes?

  • - Does the translations are up to date?

  • - Does it well tested?

  • - Tested for Chrome.

  • - Tested for Safari.

  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.

  • - Rebase your branch onto master and upstream branch

  • - Is there any redundant or duplicate code?

  • - Are required links are linked to PR?

  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@haiodo
Copy link
Member

haiodo commented Jan 16, 2023

@disant1 Please add screenshots for UI changes if possible. Thanks.

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1 disant1 requested a review from haiodo January 16, 2023 14:00
packages/presentation/package.json Outdated Show resolved Hide resolved
packages/presentation/src/components/AssigneeBox.svelte Outdated Show resolved Hide resolved
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1 disant1 requested a review from haiodo January 18, 2023 07:05
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@haiodo haiodo merged commit e9cc9e7 into main Jan 19, 2023
@haiodo haiodo deleted the tsk-360-assignee-selection-enchancements branch January 19, 2023 07:49
ThetaDR pushed a commit that referenced this pull request Jan 19, 2023
Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants