Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-553: Fix padding in assignee popup #2531

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

disant1
Copy link
Contributor

@disant1 disant1 commented Jan 23, 2023

Signed-off-by: Denis Maslennikov denis.maslennikov@gmail.com

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@disant1 disant1 requested a review from haiodo January 23, 2023 07:55
{#if cl.icon}
<Icon icon={cl.icon} size={'small'} />
{/if}
<Label label={getCategorytitle(category)} />
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure gap-1 and gap-2 are working properly, better to add ml-1 to this div.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. fixed.
Screenshot 2023-01-23 at 21 02 52

Signed-off-by: Denis Maslennikov <denis.maslennikov@gmail.com>
@haiodo haiodo merged commit a5e512c into main Jan 23, 2023
@haiodo haiodo deleted the tsk-553-add-padding-assignee-selector branch January 23, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants