Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-679: Add Whatsapp #2651

Merged
merged 1 commit into from
Feb 17, 2023
Merged

TSK-679: Add Whatsapp #2651

merged 1 commit into from
Feb 17, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Feb 17, 2023

TSK-679: Add Whatsapp

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
TSK-679: Add Whatsapp
974cce8 
TSK-679: Add Whatsapp
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis February 17, 2023 02:31
BykhovDenis
BykhovDenis approved these changes Feb 17, 2023
View reviewed changes
models/contact/src/index.ts
label: contact.string.Whatsapp,
icon: contact.icon.Whatsapp,
placeholder: contact.string.WhatsappPlaceholder,
action: contact.actionImpl.OpenChannel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's extra, we cannot open WhatsApp now

@BykhovDenis BykhovDenis merged commit 02311af into main Feb 17, 2023
@BykhovDenis BykhovDenis deleted the TSK-679 branch February 17, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis