Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-840: Fixed the display of Filtered views #2743

Merged
merged 1 commit into from
Mar 16, 2023
Merged

TSK-840: Fixed the display of Filtered views #2743

merged 1 commit into from
Mar 16, 2023

Conversation

SasLord
Copy link
Member

@SasLord SasLord commented Mar 16, 2023

Contribution checklist

Brief description

Снимок экрана 2023-03-16 в 03 09 05

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues TSK-840

View in Huly UBERF-2167

Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@@ -56,12 +58,25 @@
navigate(fv.location)
$filterStore = JSON.parse(fv.filters)
}
$: fs = $filterStore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its extra variable, why don't use $filterStore directly?

$: fs = $filterStore
$: if (Array.isArray(fs) && Array.isArray(filteredViews)) {
const filters = JSON.stringify(fs)
selectedFW = filteredViews.filter((fv) => fv.filters === filters)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check location too?)

@haiodo haiodo merged commit 0b5e785 into main Mar 16, 2023
@haiodo haiodo deleted the fix-840 branch March 16, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants