Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-858: Send picture without text as comment for issues #2793

Merged
merged 4 commits into from
Mar 23, 2023
Merged

TSK-858: Send picture without text as comment for issues #2793

merged 4 commits into from
Mar 23, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Mar 21, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-858

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR
TSK-858: dispatch when has attachments
7e549a1 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR ThetaDR requested a review from haiodo March 21, 2023 12:52
ThetaDR added 2 commits March 22, 2023 10:52
@ThetaDR
TSK-858: Handle if empty in ReferenceInput
e0ba4a0 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-858: Handle if empty inside the component itself
bf82013 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
TSK-858: Correctly revert changes
e34dbcd 
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@haiodo haiodo merged commit 8ffc0b6 into main Mar 23, 2023
@haiodo haiodo deleted the TSK-858 branch March 23, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo