Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-950: Remove value from filter if the object doesn't exist #2852

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Mar 29, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-950

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR ThetaDR requested a review from BykhovDenis March 29, 2023 07:11
ThetaDR added 3 commits March 31, 2023 16:58
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
…rrectly handle when 0 values are set to filter value

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@BykhovDenis BykhovDenis merged commit cbd6bbd into main Apr 3, 2023
@BykhovDenis BykhovDenis deleted the TSK-950 branch April 20, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants